Fix failing wcwidth "wide character" tests by reverting bad ANSI code #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still not correct; Switching to a Work In Progress |
o Tests pass with/without wcwidth module installed o Include some linting changes
|
OK, this works now with/without wcwidth installed. Turns out it was mostly just that self._len wasn't being used. However, the code used to go into an infinite loop because of a dangerous exit condition in the chunk length calculation; I fixed that to use a limited range instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wcwidth based "wide character" support is badly broken.
By reverting the code related to ANSI codes recently added (early to mid 2024), the wide character tests resume working.
I reviewed the base code from the Python textwrap module (including versions prior to the hyphen support), and compared these to the pre-ANSI code in the _handle_long_words function:
https://github.com/python/cpython/blob/06c779474c7f53bccb8ebf42c66e73b2488bf488/Lib/textwrap.py#L197
I came to the conclusion that the ANSI support here was totally broken (didn't use self._len, went into infinite loops in 2 places, etc.), so needed to be reverted and re-thought.
After this, all the wide character tests resumed working.