minor change to fix issue preventing passing in an interable for showindex #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if the vertical line separating the index from the table could have the same format as the horizontal line separating the headers from the table. Would someone be able to implement that? |
|
I do not understand why there is a failing check -- I have barely changed anything. Assistance would be appreciated. |
|
The failing test on Appveyor is not related to this PR. Still before I can accept this PR I need unit tests (test/test_input.py, test/test_output.py) and a reference to an issue it tries to solve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check that
showindex_is_a_strbefore comparingshowindex == "default", which causes an error whenshowindexis an iterable.