Skip to content

Renders GitHub-Flavored Markdown tables in canonical format #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kdeldycke
Copy link
Contributor

In the GitHub Flavored Markdown Spec, tables are formatted in all sorts of shapes.

But one common aspect is that the pipes separating the cells are padded by a space. This is acknowledged in python-tabulate with the padding=1 settings. But unfortunately this setting doesn't applies to the lineabove and linebelowheader lines.

This PR fixes this issue, by having the line separators renders with padding spaces between the pipes and dashes.

kdeldycke added a commit to kdeldycke/click-extra that referenced this pull request Apr 4, 2023
@kdeldycke
Copy link
Contributor Author

All tests are passing, this PR is ready to be merged upstream.

kdeldycke added a commit to kdeldycke/python-tabulate that referenced this pull request Apr 4, 2023
kdeldycke added a commit to kdeldycke/python-tabulate that referenced this pull request Apr 4, 2023
@kdeldycke
Copy link
Contributor Author

This PR has been superseded by #261.

@kdeldycke kdeldycke closed this Apr 4, 2023
@kdeldycke kdeldycke deleted the gfm-formatted-tables branch April 4, 2023 14:22
kdeldycke added a commit to kdeldycke/python-tabulate that referenced this pull request Apr 4, 2023
kdeldycke added a commit to kdeldycke/python-tabulate that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant