Skip connection reset tests on macOS in 2.1 (#2942)

halter73 · web-flow · commit 15ba5065a9b2 · 2018-09-18T14:11:28.000-07:00
diff --git a/test/Kestrel.FunctionalTests/HttpsTests.cs b/test/Kestrel.FunctionalTests/HttpsTests.cs
@@ -18,6 +18,7 @@
 using Microsoft.AspNetCore.Server.Kestrel.Https;
 using Microsoft.AspNetCore.Server.Kestrel.Https.Internal;
 using Microsoft.AspNetCore.Testing;
+using Microsoft.AspNetCore.Testing.xunit;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Abstractions.Internal;
@@ -331,7 +332,8 @@ await sslStream.AuthenticateAsClientAsync("127.0.0.1", clientCertificates: null,
         }
 
         // Regression test for https://github.com/aspnet/KestrelHttpServer/pull/1197
-        [Fact]
+        [ConditionalFact]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         public void ConnectionFilterDoesNotLeakBlock()
         {
             var loggerProvider = new HandshakeErrorLoggerProvider();
diff --git a/test/Kestrel.FunctionalTests/RequestTests.cs b/test/Kestrel.FunctionalTests/RequestTests.cs
@@ -264,7 +264,8 @@ public void CanUpgradeRequestWithConnectionKeepAliveUpgradeHeader()
             Assert.True(dataRead);
         }
 
-        [Fact]
+        [ConditionalFact]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         public async Task ConnectionResetPriorToRequestIsLoggedAsDebug()
         {
             var connectionStarted = new SemaphoreSlim(0);
@@ -325,7 +326,8 @@ public async Task ConnectionResetPriorToRequestIsLoggedAsDebug()
             Assert.False(loggedHigherThanDebug);
         }
 
-        [Fact]
+        [ConditionalFact]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         public async Task ConnectionResetBetweenRequestsIsLoggedAsDebug()
         {
             var connectionReset = new SemaphoreSlim(0);
@@ -394,7 +396,8 @@ await connection.Receive(
             Assert.False(loggedHigherThanDebug);
         }
 
-        [Fact]
+        [ConditionalFact]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         public async Task ConnectionResetMidRequestIsLoggedAsDebug()
         {
             var requestStarted = new SemaphoreSlim(0);
@@ -463,7 +466,8 @@ public async Task ConnectionResetMidRequestIsLoggedAsDebug()
             Assert.False(loggedHigherThanDebug, "Logged event should not have been higher than debug.");
         }
 
-        [Fact]
+        [ConditionalFact]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         public async Task ThrowsOnReadAfterConnectionError()
         {
             var requestStarted = new SemaphoreSlim(0);
@@ -1305,7 +1309,8 @@ await connection.Send(
             mockKestrelTrace.Verify(t => t.ConnectionStop(It.IsAny<string>()), Times.AtMostOnce());
         }
 
-        [Theory]
+        [ConditionalTheory]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         [MemberData(nameof(ConnectionAdapterData))]
         public async Task AppCanHandleClientAbortingConnectionMidRequest(ListenOptions listenOptions)
         {
diff --git a/test/Kestrel.FunctionalTests/ResponseTests.cs b/test/Kestrel.FunctionalTests/ResponseTests.cs
@@ -27,6 +27,7 @@
 using Microsoft.AspNetCore.Server.Kestrel.Https;
 using Microsoft.AspNetCore.Server.Kestrel.Https.Internal;
 using Microsoft.AspNetCore.Testing;
+using Microsoft.AspNetCore.Testing.xunit;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Testing;
@@ -2431,7 +2432,8 @@ await connection.Send(
             Assert.True(requestAborted);
         }
 
-        [Theory]
+        [ConditionalTheory]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         [MemberData(nameof(ConnectionAdapterData))]
         public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions)
         {
@@ -2504,7 +2506,8 @@ await connection.Send(
             Assert.Empty(transportLogs.Where(w => w.LogLevel > LogLevel.Debug));
         }
 
-        [Theory]
+        [ConditionalTheory]
+        [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]
         [MemberData(nameof(ConnectionAdapterData))]
         public async Task ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug(ListenOptions listenOptions)
         {

Original file line number	Diff line number	Diff line change
`@@ -264,7 +264,8 @@ public void CanUpgradeRequestWithConnectionKeepAliveUpgradeHeader()`
`264`	`264`	`Assert.True(dataRead);`
`265`	`265`	`}`
`266`	`266`
`267`		`- [Fact]`
	`267`	`+ [ConditionalFact]`
	`268`	`+ [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]`
`268`	`269`	`public async Task ConnectionResetPriorToRequestIsLoggedAsDebug()`
`269`	`270`	`{`
`270`	`271`	`var connectionStarted = new SemaphoreSlim(0);`
`@@ -325,7 +326,8 @@ public async Task ConnectionResetPriorToRequestIsLoggedAsDebug()`
`325`	`326`	`Assert.False(loggedHigherThanDebug);`
`326`	`327`	`}`
`327`	`328`
`328`		`- [Fact]`
	`329`	`+ [ConditionalFact]`
	`330`	`+ [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]`
`329`	`331`	`public async Task ConnectionResetBetweenRequestsIsLoggedAsDebug()`
`330`	`332`	`{`
`331`	`333`	`var connectionReset = new SemaphoreSlim(0);`
`@@ -394,7 +396,8 @@ await connection.Receive(`
`394`	`396`	`Assert.False(loggedHigherThanDebug);`
`395`	`397`	`}`
`396`	`398`
`397`		`- [Fact]`
	`399`	`+ [ConditionalFact]`
	`400`	`+ [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]`
`398`	`401`	`public async Task ConnectionResetMidRequestIsLoggedAsDebug()`
`399`	`402`	`{`
`400`	`403`	`var requestStarted = new SemaphoreSlim(0);`
`@@ -463,7 +466,8 @@ public async Task ConnectionResetMidRequestIsLoggedAsDebug()`
`463`	`466`	`Assert.False(loggedHigherThanDebug, "Logged event should not have been higher than debug.");`
`464`	`467`	`}`
`465`	`468`
`466`		`- [Fact]`
	`469`	`+ [ConditionalFact]`
	`470`	`+ [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]`
`467`	`471`	`public async Task ThrowsOnReadAfterConnectionError()`
`468`	`472`	`{`
`469`	`473`	`var requestStarted = new SemaphoreSlim(0);`
`@@ -1305,7 +1309,8 @@ await connection.Send(`
`1305`	`1309`	`mockKestrelTrace.Verify(t => t.ConnectionStop(It.IsAny<string>()), Times.AtMostOnce());`
`1306`	`1310`	`}`
`1307`	`1311`
`1308`		`- [Theory]`
	`1312`	`+ [ConditionalTheory]`
	`1313`	`+ [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]`
`1309`	`1314`	`[MemberData(nameof(ConnectionAdapterData))]`
`1310`	`1315`	`public async Task AppCanHandleClientAbortingConnectionMidRequest(ListenOptions listenOptions)`
`1311`	`1316`	`{`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`	`using Microsoft.AspNetCore.Server.Kestrel.Https;`
`28`	`28`	`using Microsoft.AspNetCore.Server.Kestrel.Https.Internal;`
`29`	`29`	`using Microsoft.AspNetCore.Testing;`
	`30`	`+using Microsoft.AspNetCore.Testing.xunit;`
`30`	`31`	`using Microsoft.Extensions.DependencyInjection;`
`31`	`32`	`using Microsoft.Extensions.Logging;`
`32`	`33`	`using Microsoft.Extensions.Logging.Testing;`
`@@ -2431,7 +2432,8 @@ await connection.Send(`
`2431`	`2432`	`Assert.True(requestAborted);`
`2432`	`2433`	`}`
`2433`	`2434`
`2434`		`- [Theory]`
	`2435`	`+ [ConditionalTheory]`
	`2436`	`+ [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]`
`2435`	`2437`	`[MemberData(nameof(ConnectionAdapterData))]`
`2436`	`2438`	`public async Task AppCanHandleClientAbortingConnectionMidResponse(ListenOptions listenOptions)`
`2437`	`2439`	`{`
`@@ -2504,7 +2506,8 @@ await connection.Send(`
`2504`	`2506`	`Assert.Empty(transportLogs.Where(w => w.LogLevel > LogLevel.Debug));`
`2505`	`2507`	`}`
`2506`	`2508`
`2507`		`- [Theory]`
	`2509`	`+ [ConditionalTheory]`
	`2510`	`+ [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "macOS EPIPE vs. EPROTOTYPE bug https://github.com/aspnet/KestrelHttpServer/issues/2885")]`
`2508`	`2511`	`[MemberData(nameof(ConnectionAdapterData))]`
`2509`	`2512`	`public async Task ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug(ListenOptions listenOptions)`
`2510`	`2513`	`{`