Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Commit e5b2b68

Browse files
author
John Luo
committed
Fix flaky test by ignoring indeterminant response
1 parent 5ba327f commit e5b2b68

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

test/Kestrel.FunctionalTests/ChunkedRequestTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ await connection.SendAll(
678678

679679
connection.Socket.Shutdown(SocketShutdown.Send);
680680

681-
await connection.ReceiveEnd();
681+
await connection.ReceiveEnd(ignoreResponse: true);
682682

683683
var badReqEx = await exTcs.Task.TimeoutAfter(TestConstants.DefaultTimeout);
684684
Assert.Equal(RequestRejectionReason.UnexpectedEndOfRequestContent, badReqEx.Reason);

test/shared/TestConnection.cs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,20 @@ public async Task Receive(params string[] lines)
149149
Assert.Equal(expected, new string(actual, 0, offset));
150150
}
151151

152-
public async Task ReceiveEnd(params string[] lines)
152+
public Task ReceiveEnd(params string[] lines)
153+
=> ReceiveEnd(false, lines);
154+
155+
public async Task ReceiveEnd(bool ignoreResponse, params string[] lines)
153156
{
154157
await Receive(lines).ConfigureAwait(false);
155158
_socket.Shutdown(SocketShutdown.Send);
156159
var ch = new char[128];
157160
var count = await _reader.ReadAsync(ch, 0, 128).TimeoutAfter(Timeout).ConfigureAwait(false);
158-
var text = new string(ch, 0, count);
159-
Assert.Equal("", text);
161+
if (!ignoreResponse)
162+
{
163+
var text = new string(ch, 0, count);
164+
Assert.Equal("", text);
165+
}
160166
}
161167

162168
public async Task ReceiveForcedEnd(params string[] lines)

0 commit comments

Comments
 (0)