Skip to content

refactor: normalize root/out/declaration dir in macro #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

refactor: normalize root/out/declaration dir in macro #810

merged 1 commit into from
May 31, 2025
+14 −9

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented May 26, 2025

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from Aghassi May 26, 2025 17:43
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented May 26, 2025 •
edited
Loading

Test

All tests were cache hits

173 tests (100.0%) were fully cached saving 12s.

Buildifier      Format

@jbedard jbedard requested a review from thesayyn May 30, 2025 19:34
@jbedard jbedard merged commit 95c96c6 into aspect-build:main May 31, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

@Aghassi Aghassi Awaiting requested review from Aghassi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @thesayyn