refactor: only pass --outDir flag when needed #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the severity of the workaround needed for TS #59036
|
|
Note, the failing test is red on |
jbedard
reviewed
Oct 18, 2024
jbedard
approved these changes
Oct 18, 2024
|
Double check the worker CI failure before any merging 🙏 |
alexeagle
added a commit
that referenced
this pull request
Oct 21, 2024
This reverts commit 28ea057.
|
FWIW: This change causes the Maybe it is worth adjusting the config validator to check it isn't there / it is consistent. |
|
Yes jbedard already noticed that at some customers, I think there's an issue and a fix already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the severity of the workaround needed for TS #59036