-
-
Notifications
You must be signed in to change notification settings - Fork 149
refactor: stop reading pnpm_lock from label_store #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
ada7413
to
a4d64b3
Compare
a4d64b3
to
122d1ae
Compare
122d1ae
to
9b7653c
Compare
9b7653c
to
1b8c6f2
Compare
1b8c6f2
to
ef88540
Compare
We should stop using label_store completely; it served a useful purpose to precompute labels when restarts were expensive, but that's no longer true in modern bazels. We can use the labels direcly from
rctx.attr
and simplify some indirection.Note that we still touch the label early so even for non-modern bazels this should not be a performance degradation.
Test plan
existing tests