Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Add support for filter chaining in filter blocks #984

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Add support for filter chaining in filter blocks #984

merged 4 commits into from
Mar 11, 2024

Conversation

GuillaumeGomez
Copy link
Collaborator

Follow-up of #959.

It allows to chain filters on filter blocks, making the feature much more useful. :)

With this, the feature will be complete.

@GuillaumeGomez GuillaumeGomez requested review from djc and Kijewski March 7, 2024 18:13
djc
djc reviewed Mar 8, 2024
View reviewed changes
@GuillaumeGomez
Copy link
Collaborator Author

Applied suggestions.

djc
djc reviewed Mar 8, 2024
View reviewed changes
@GuillaumeGomez
Copy link
Collaborator Author

Created a new Filter type in its own commit. It required to update a lot of tests, forcing me to remove the use Expr::* because of name conflict, it's mostly because of cases like this that I'm not a big fan matching on just variant names. 😉

@GuillaumeGomez
Copy link
Collaborator Author

Fixed the commit mess. :)

djc
djc reviewed Mar 8, 2024
View reviewed changes
djc
djc reviewed Mar 8, 2024
View reviewed changes
@GuillaumeGomez
Copy link
Collaborator Author

Renamed and added documentation.

@GuillaumeGomez GuillaumeGomez merged commit 3026829 into askama-rs:main Mar 11, 2024
16 checks passed
@GuillaumeGomez GuillaumeGomez deleted the filter-doc-chaining branch March 11, 2024 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djc djc djc approved these changes

@Kijewski Kijewski Awaiting requested review from Kijewski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @Kijewski @djc