do manual rel subquery regardless of no_attributes for aggregates #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregates 1. Refactor a large conditional branch in `AshSql.Aggregate.get_subquery` to use a new multi-head private function instead of nested ifs. 2. Make it so that the case where the relationship is manual matches BEFORE the case where the relationship is no_attributes?: true This is necessary in order to pass ash_postgres tests when running against ash with this PR applied: ash-project/ash#2562
7 tasks
zachdaniel
approved these changes
Feb 11, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AshSql.Aggregate.get_subqueryto use a new multi-head private function instead of nested ifs.This is necessary in order to pass ash_postgres tests when running against ash with this PR applied: ash-project/ash#2562
I tested this change via the ash_postgres tests using this branch.
This should be safe to merge before the above PR, since it should only affect cases where people have defined
no_attributes?: trueon a manual relationship, and are aggregating through said relationship.Contributor checklist
Leave anything that you believe does not apply unchecked.