Skip to content

test: added regression test for aggregate with action with modify query #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TommasoAmici
Copy link

Regression test for #596

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel zachdaniel closed this Jul 21, 2025
@zachdaniel
Copy link
Contributor

Unfortunately, the fix here is going to be that we can't support aggregates that use read actions that have a modify_query option. Its just too complex to implement due to the various ways that aggregate queries are built.

@zachdaniel
Copy link
Contributor

I will add an error message explaining that this is not currently possible in Ash core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants