Add support for Fasta records #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sstadick. This looks awesome! |
|
Hi @aseyboldt, thanks for getting back to me on this! No worries on timeline, I'm just glad this popped up on your radar. I'm pretty sure I'm not the only user of this: https://crates.io/crates/fastq |
|
Hi @aseyboldt, just wanted to bump this PR and see if you've had a chance to look at it. |
|
@aseyboldt Just wanted to check in on this and see where things were at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I love your library for how easy it makes it to offload the decompression / reading to a different thread. I often need the same thing for fasta files, so I've tried to add it to what you already have. I tried to take the path of least resistance here.
All tests pass, and the fuzzer seems happy. I have not tried to benchmark to see if I've made it slower than before though. How did you run the original benchmarks?
Lastly, if you'd prefer to keep fastq as is, I'm happy to maintain this fork and rename it something else to indicate it is more than just a fastq parser.