Skip to content

feat: allow extra filtering fields #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

enkhjile
Copy link

@enkhjile enkhjile commented Jan 2, 2025

Hello, I'm the guy who opened #600. If you think that the implementation is good enough, I will proceed to update the documentation accordingly.

Edit: I've updated the docs

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for fastapi-filter ready!

Name Link
🔨 Latest commit 0fd8574
🔍 Latest deploy log https://app.netlify.com/sites/fastapi-filter/deploys/677928b0839e140008e3d104
😎 Deploy Preview https://deploy-preview-619--fastapi-filter.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7dd2f2c) to head (0fd8574).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #619   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          237       239    +2     
=========================================
+ Hits           237       239    +2     
Files with missing lines Coverage Δ
fastapi_filter/base/filter.py 100.00% <100.00%> (ø)

@enkhjile enkhjile changed the title feat: allow ignoring fields during filtering feat: allow extra filtering fields Jan 4, 2025
@enkhjile enkhjile force-pushed the main branch 3 times, most recently from 432934f to 52476b2 Compare January 4, 2025 12:18
@enkhjile
Copy link
Author

enkhjile commented Jan 7, 2025

@arthurio
Hello, can you review this? (Somehow test workflow on python 3.9 failed during codecov upload)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant