Merge pull request #121 from HaakonEidemHaakstad/master

Rewrite a loop as list comprehension.
arshadkazmi42 · Nov 13, 2024 · 11efcb1 · 11efcb1
2 parents 0660aba + 475c079
commit 11efcb1
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/first_timers/first_timers.py b/first_timers/first_timers.py
@@ -46,10 +46,8 @@ def get_first_timer_issues(issue_label: str) -> list:
     res = requests.get(FIRST_ISSUE_QUERY_URL.format(issue_label))
     res.raise_for_status()
 
-    items = []
-    for item in res.json()['items']:
-        if check_days_passed(item['created_at'], DAYS_OLD):
-            items.append(item)
+    items = [item for item in res.json()['items']
+            if check_days_passed(item['created_at'], DAYS_OLD)]
 
     return items