-
Notifications
You must be signed in to change notification settings - Fork 59
v3.5.0 devel to master #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,432
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
9prady9
commented
Jun 28, 2017
•
edited
Loading
edited
- Release Notes
- Documentation Update
Master to Devel Merge post v3.4.3 Release
This change also includes the fixes for currently missing documentation and crate level documentation.
Earlier to this change, documentation was generated using the command `cargo doc`. However, this has one drawback - when external markdown files were used, additional set of commands had to be run using `rustdoc` tool to generate the html files corresponding to the md files. With this change, `generate_docs.sh` bash script will handle those intricacies of running `cargo doc` followed by execution of `rustdoc` for external md files. This change adds the following tutorials to the documetation. * Getting Started with ArrayFire * Introduction to Vectorization * Array and Matrix Manipulation * Indexing * Configure ArrayFire Environment
Remove rustc_serialize in favor of Serde crate
Add tutorials with examples to Documentation
The Array objects used by Indexer objects were not properly incrementing the reference count. This led to memory corruption and undefined behaviour which is fixed now.
starting commit d558748 rustc-serialize has been replaced in favor of serde. Serde requires rust 1.15.1. Thus, README has been updated reflecting the same.
Bug Fixes
Currently, only Seq and Array implement the Indexable trait. Earlier to this change, there was no proper lifetime specification for Indexer struct and Indexer::set_index method to enfore borrow checking. This should be fixed now.
This issue doesn't happen on Windows and Linux. Creating an Array from `&[]` directly instead of creating a vector first and then borrowing a slice is causing crash on OSX platform.
This removed the need to impl unsafe Send & Sync traits for Callback type. Also updated the error handler test to be more rusty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.