vng: fail if --arch is used without --root
#234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arighi
reviewed
Feb 9, 2025
Because it doesn't make sense to run on a different architecture, but with the host's root FS. Hopefully this is not going to block weird use-cases. Link: arighi#233 Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
matttbe
changed the title
--arch is used without --root
Instead of only listing the one passed by the user: most likely, the user will want to know what to use. While at it, add a comment at the end of ARCH_MAPPING to think about updating get_host_arch() when adding a new arch. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
arighi
approved these changes
Feb 10, 2025
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it doesn't make sense to run on a different architecture, but with the host's root FS.
Hopefully this is not going to block weird use-cases.
Link: #233