virtme: always print kernel panic / oops in interactive mode #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matttbe
reviewed
Jan 30, 2025
arighi
force-pushed
the
show-kernel-panic
branch
from
3be4f32 to
ebf93bd
Compare
matttbe
approved these changes
Jan 30, 2025
| else: | ||
| print( | ||
| "WARNING: not a valid pts, try to run vng inside tmux or screen", | ||
| file=sys.stderr, |
There was a problem hiding this comment.
just to be sure: can we still write to stderr here if we cannot access /proc/self/fd/2?
Also, compared to before, this warning will always be printed in such environment, when stderr is not accessible. I guess it will not be an issue, right?
arighi
force-pushed
the
show-kernel-panic
branch
from
ebf93bd to
98cef38
Compare
matttbe
approved these changes
Jan 30, 2025
arighi
force-pushed
the
show-kernel-panic
branch
from
98cef38 to
503e9da
Compare
As mentioned in #217 it would be nice to always print the output of critical kernel errors (oops / panic), instead of suppressing all the kernel logs completely by default. Therefore, keep suppressing the boot kernel log, but always dump panic/oops to stderr by default when running in interactive mode. Example with this change applied: arighi@virtme-ng~/s/linux (master)> vng _ _ __ _(_)_ __| |_ _ __ ___ ___ _ __ __ _ \ \ / / | __| __| _ _ \ / _ \_____| _ \ / _ | \ V /| | | | |_| | | | | | __/_____| | | | (_| | \_/ |_|_| \__|_| |_| |_|\___| |_| |_|\__ | |___/ kernel version: 6.13.0-virtme x86_64 (CTRL+d to exit) arighi@virtme-ng~/s/linux (master)> echo c | sudo tee /proc/sysrq-trigger [ 8.923672] sysrq: Trigger a crash [ 8.923980] Kernel panic - not syncing: sysrq triggered crash [ 8.924183] CPU: 0 UID: 0 PID: 198 Comm: tee Not tainted 6.13.0-virtme #2 [ 8.924632] Call Trace: [ 8.924704] <TASK> [ 8.924783] panic+0x349/0x3b0 [ 8.925055] sysrq_handle_crash+0x36/0x80 [ 8.925181] __handle_sysrq+0xed/0x270 [ 8.925274] write_sysrq_trigger+0x6a/0x90 [ 8.925380] proc_reg_write+0x56/0xa0 [ 8.925489] vfs_write+0x105/0x590 [ 8.925600] ksys_write+0x74/0xf0 [ 8.925682] do_syscall_64+0xbb/0x1d0 [ 8.925767] entry_SYSCALL_64_after_hwframe+0x77/0x7f [ 8.925891] RIP: 0033:0x7fdfed54ba84 Signed-off-by: Andrea Righi <[email protected]>
arighi
force-pushed
the
show-kernel-panic
branch
from
503e9da to
19c7f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #217 it would be nice to always print the output of critical kernel errors (oops / panic), instead of suppressing all the kernel logs completely by default.
Therefore, keep suppressing the boot kernel log, but always dump panic/oops to stderr by default when running in interactive mode.
Example with this change applied:
Closes: #217