version: make sure to get the git version from a virtme-ng git repo

When we run git describe to append the git information to the version string, make sure that the version.py module is contained in a virtme-ng git repository, to avoid using information from any git repository in any parent directory. Reported-by: Matthieu Baerts (NGI0) <[email protected]> Signed-off-by: Andrea Righi <[email protected]>
arighi · Jul 14, 2024 · 30d7c33 · 30d7c33
1 parent 0ded79a
commit 30d7c33
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/virtme_ng/version.py b/virtme_ng/version.py
@@ -11,10 +11,16 @@
 
 def get_version_string():
     try:
-        # Get the version from git describe
+        # Get the version from `git describe`.
+        #
+        # Make sure to get the proper git repository by using the directory
+        # that contains this file and also make sure that the parent is a
+        # virtme-ng repository.
+        #
+        # Otherwise fallback to the static version defined in PKG_VERSION.
         version = (
             check_output(
-                "cd %s && git describe --always --long --dirty" % os.path.dirname(__file__),
+                "cd %s && [ -e ../.git ] && git describe --always --long --dirty" % os.path.dirname(__file__),
                 shell=True,
                 stderr=DEVNULL,
             )