fix: hide session pinning feature to avoid conflict with bookmarking#282
Open
ariane-emory wants to merge 1 commit into
Open
fix: hide session pinning feature to avoid conflict with bookmarking#282ariane-emory wants to merge 1 commit into
ariane-emory wants to merge 1 commit into
Conversation
The dev branch has a built-in session pinning feature that uses local storage and shows slot numbers. This conflicts with the feat/session-bookmarks branch which provides a more robust server-synced bookmarking system. Changes: - Remove pin/unpin action from session list dialog - Remove slot number gutters from session list items - Remove quick-switch footer hints - Remove pin-related tips from tips view The keybind definition and local storage are preserved to maintain backward compatibility with existing user configurations. The feature is simply no longer exposed in the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Hide session pinning UI to avoid conflict with bookmarking
Problem
The dev branch includes a built-in session pinning feature that:
~/.local/state/opencode/session.json)ctrl+fto pin/unpin in the session list dialogThis conflicts with
feat/session-bookmarks(PR#102), which provides a more robust server-synced bookmarking system that stores pin state on the session object itself (session.time.pinned).Solution
Remove the UI exposure of the dev branch's local pinning feature while preserving backward compatibility:
Files Changed
packages/opencode/src/cli/cmd/tui/component/dialog-session-list.tsx— Removed pin action, slot gutters, and quick-switch hintspackages/opencode/src/cli/cmd/tui/feature-plugins/home/tips-view.tsx— Removed pin-related tipsBackward Compatibility
Existing user configurations with
session_pin_togglekeybinds are preserved. The keybind simply has no visible effect in the UI. Whenfeat/session-bookmarksis present, the server-synced bookmarking system takes over entirely.