fix(dialog-select): preserve selection when options reorder#280
Open
ariane-emory wants to merge 2 commits into
Open
fix(dialog-select): preserve selection when options reorder#280ariane-emory wants to merge 2 commits into
ariane-emory wants to merge 2 commits into
Conversation
When options are reordered (e.g., favorite/unfavorite in model list), the highlighted selection was staying at the same row index and pointing to a different item. Now we use on(() => flat(), ...) with the previous flat array to find the previously selected value in the new options list and restore the selection to the correct index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
When options are reordered (e.g., favourite/unfavourite in model list), the highlighted selection was staying at the same row index and pointing to a different item. Now we use on(() => flat(), ...) with the previous flat array to find the previously selected value in the new options list and restore the selection to the correct index.
This means that when the
ctrl+fkey is used to favourite or unfavourite their model in themodel_list, the selection will remain on the same model instead of remaining on the same index (which will now contain a different model).