fix: preserve quotes in slash command arguments#239
Open
ariane-emory wants to merge 16 commits into
Open
Conversation
Remove quoteTrimRegex that was stripping single and double quotes from all arguments. This allows users to intentionally include quotes in argument values, which is necessary for commands that need to preserve quote characters.
# Conflicts: # packages/opencode/src/session/prompt.ts
Normalize session command arguments with the existing quoted-token regex and trim surrounding quotes before placeholder substitution. This keeps runtime slash-command expansion aligned with baseone expand for multi-word quoted arguments.
Parse quoted command arguments as single tokens before placeholder substitution so runtime command execution matches shell-style quoting. Add focused regression coverage for quoted argument parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Remove quoteTrimRegex that was stripping single and double quotes from all arguments. This allows users to intentionally include quotes in argument values, which is necessary for commands that need to preserve quote characters.