fix: health hpa when only second conditions is False #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnaud Farbos <[email protected]>
afarbos
force-pushed
the
af/FixHAPHealth
branch
from
8b33147 to
abd0af5
Compare
Signed-off-by: Arnaud Farbos <[email protected]>
afarbos
force-pushed
the
af/FixHAPHealth
branch
from
abd0af5 to
4d25c5a
Compare
Signed-off-by: Arnaud Farbos <[email protected]>
|
|
The gitops-engine repository is migrating to https://github.com/argoproj/argo-cd. We are closing all draft PRs. |
This MR was not in draft and ready for review any chance to get a quick look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the health check return healthy if the first conditions is healthy.
This fix, first verify all conditions are healthy before returning healthy, allowing to catch when the first conditions is healthy but not the second.