Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiments): propagate rollouts labels to experiments and replicasets #4118

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

ayureidini
Copy link
Contributor

@ayureidini ayureidini commented Feb 6, 2025

Enhancement ticket: #4113

This can be useful for complying to Tagging Policy imposed at cluster level since there is no mechanism to add custom labels to Experiments and their associated ReplicaSets.
Indeed, this could enable automatic reporting but also give required information for investigation.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@ayureidini ayureidini force-pushed the fix_labels_exp_rs branch 2 times, most recently from b07c667 to e39a09f Compare February 6, 2025 18:08
… sets

Enhancement ticket: argoproj#4113
This can be useful for complying to Tagging Policy imposed at cluster level
since there is no mechanism to add custom labels to Experiments and their
associated ReplicaSets.
Indeed, this could enable automatic reporting but also give required information
for investigation.

Signed-off-by: Ahmed YUREIDINI NOGALES <[email protected]>
Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Published E2E Test Results

  4 files    4 suites   3h 10m 2s ⏱️
113 tests 104 ✅  7 💤 2 ❌
454 runs  424 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit d910725.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Published Unit Test Results

2 295 tests   2 295 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit d910725.

@zachaller zachaller merged commit 420aacb into argoproj:master Feb 7, 2025
24 checks passed
@zachaller zachaller changed the title fix(experiments): propagate rolouts labels to experiments and replicasets fix(experiments): propagate rollouts labels to experiments and replicasets Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants