feat: add requeueAfterSeconds to spec.generator.matrix.generator.matrix.generator.git schema
#716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trix.generator.git schema Signed-off-by: chansuke <[email protected]>
chansuke
requested review from
blakepettersson,
mkilchhofer,
oboukili,
onematchfox and
the-technat
as code owners
Signed-off-by: chansuke <[email protected]>
the-technat
requested changes
Aug 25, 2025
Collaborator
the-technat
left a comment
the-technat
left a comment
There was a problem hiding this comment.
Thanks for your PR!
The new schema field is missing in some other places.
Take a look at this commit that introduced a similar field on the Git Generator to see where it's missing too.
For the documentation part, you can run make generate and given the schema in-code is properly defined it will render the docs with the new field.
Signed-off-by: chansuke <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
Stale
the-technat
added
on-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #703