-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Add AzureDevops ScmProvider #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 50.90% 47.06% -3.85%
==========================================
Files 35 39 +4
Lines 4186 4791 +605
==========================================
+ Hits 2131 2255 +124
- Misses 1801 2280 +479
- Partials 254 256 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crenshaw-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick first pass, it's looking good!
Signed-off-by: Endre Egseth <[email protected]>
…erConfiguration API (argoproj-labs#549) * Add dynamic controller configuration with WorkQueue settings - Implement dual-client approach for reading configuration during setup - Add Direct methods to read from API server bypassing cache - Support generic rate limiter types for different request types - Update all controllers to use configurable WorkQueue settings - Add comprehensive ControllerConfiguration.yaml documentation Signed-off-by: Zach Aller <[email protected]> * fix default config Signed-off-by: Zach Aller <[email protected]> * fix validation Signed-off-by: Zach Aller <[email protected]> * fix test Signed-off-by: Zach Aller <[email protected]> * use correct configuration Signed-off-by: Zach Aller <[email protected]> * review Signed-off-by: Zach Aller <[email protected]> * switch Signed-off-by: Zach Aller <[email protected]> * lint Signed-off-by: Zach Aller <[email protected]> * test depend on 7 Signed-off-by: Zach Aller <[email protected]> * if required remove omitempty Signed-off-by: Zach Aller <[email protected]> * set reconcile routines to 1 Signed-off-by: Zach Aller <[email protected]> * set reconcile routines to 1 for CTP Signed-off-by: Zach Aller <[email protected]> * remove lock logger Signed-off-by: Zach Aller <[email protected]> * cleanup Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
…abs#559) Bumps [golang.org/x/time](https://github.com/golang/time) from 0.12.0 to 0.14.0. - [Commits](golang/time@v0.12.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-version: 0.14.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 0.154.0 (argoproj-labs#558) chore(deps): bump gitlab.com/gitlab-org/api/client-go Bumps [gitlab.com/gitlab-org/api/client-go](https://gitlab.com/gitlab-org/api/client-go) from 0.152.0 to 0.154.0. - [Release notes](https://gitlab.com/gitlab-org/api/client-go/tags) - [Changelog](https://gitlab.com/gitlab-org/api/client-go/blob/main/CHANGELOG.md) - [Commits](https://gitlab.com/gitlab-org/api/client-go/compare/v0.152.0...v0.154.0) --- updated-dependencies: - dependency-name: gitlab.com/gitlab-org/api/client-go dependency-version: 0.154.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… cluster (argoproj-labs#560) * save point Signed-off-by: Zach Aller <[email protected]> * ginkgo tests Signed-off-by: Zach Aller <[email protected]> * clean up crd check Signed-off-by: Zach Aller <[email protected]> * clean up Signed-off-by: Zach Aller <[email protected]> * save point Signed-off-by: Zach Aller <[email protected]> * remove test Signed-off-by: Zach Aller <[email protected]> * rename Signed-off-by: Zach Aller <[email protected]> * cleanup Signed-off-by: Zach Aller <[email protected]> * cleanup Signed-off-by: Zach Aller <[email protected]> * required Signed-off-by: Zach Aller <[email protected]> * add config Signed-off-by: Zach Aller <[email protected]> * formate Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
) Signed-off-by: Zach Aller <[email protected]>
Co-authored-by: zachaller <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
Signed-off-by: Endre Egseth <[email protected]>
|
Apologies for the delayed review. There was something bothering me that I couldn't quite figure out, and I think I finally made sense of it. All of the existing providers is accessible via one of two modes:
This new provider breaks that binary. If I as a namespaced tenant can create an ScmProvider, I can take advantage of the creds (the workload identity) of the controller in the admin-controlled namespace. I think that, for this PR, we should make Azure DevOps workload identity available only in ClusterScmProviders. In a follow up PR we can add workload identity support to ScmProviders in a way that requires the tenant to provide their own credentials. |
Adds Azure DevOps support as an SCM provider, with both PAT and Azure Workload Identity authentication methods.
Fixes #303