fix: Add PostStart lifecycle hook to reset Redis sentinel #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfroembgen
changed the title
Signed-off-by: Marco Frömbgen <[email protected]>
svghadi
approved these changes
Feb 25, 2025
svghadi
added a commit
that referenced
this pull request
Mar 7, 2025
)" This reverts commit 69a2076.
svghadi
added a commit
to svghadi/argocd-operator
that referenced
this pull request
Mar 7, 2025
…goproj-labs#1674)" (argoproj-labs#1682) This reverts commit 69a2076. Signed-off-by: Siddhesh Ghadi <[email protected]>
svghadi
added a commit
that referenced
this pull request
Mar 7, 2025
)" (#1682) (#1684) This reverts commit 69a2076. Signed-off-by: Siddhesh Ghadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This pull request includes a change to the
reconcileRedisStatefulSetfunction in thestatefulset.gofile to add a post-start lifecycle hook for the Redis StatefulSet. This hook ensures that the Redis Sentinel is reset after a short delay when the container starts.Argo-cd:
Issue: argoproj/argo-cd#16360
PR: argoproj/argo-cd#20645
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1664
How to test changes / Special notes to the reviewer: