Add redis cluster config

[paulbauriegel]

Support Redis Cluster

We are using a redis cluster setup, but the current code uses redis.from_url which only works for Redis Standalone. See: https://github.com/redis/redis-py/blob/ceb12fe8b52f488bd1e0a42b9dc53161e77514d0/redis/utils.py#L33

So I added a config-option to support Redis Cluster which should not break the current default behavior only extend it.

Type of change

• New feature (non-breaking change which adds functionality)
• Documentation update

How Has This Been Tested

AWS Redis cluster deployment

Checklist

• I added relevant documentation
• I followed the style guidelines of this project
• I did a self-review of my code
• I made corresponding changes to the documentation
• I confirm My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• TODO - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

[davidberenstein1957]

@paulbauriegel , would it be easy to include this too? #5800

[paulbauriegel]

It's a bit of a different feature request right?
It can be added here: https://github.com/argilla-io/argilla/blob/6d6f96e498d8ffdb524e1c99aaf81af6092dc086/examples/deployments/k8s/argilla-chart/templates/deployment.yaml
by making this

value: redis://{{ .Release.Name }}-redis-master:6379/0

configurable via the values.yaml generally I can have a look but I think it's unrelated.

[paulbauriegel]

It should work with two changes

1. in the deployments.yaml

value: {{if .Values.externalRedis.enabled}}"redis://{{ .Release.Name }}-redis-master:6379/0"{{else}}"{{ .Values.externalRedis.url }}"{{end}}

2. in the values.yml add

externalRedis:
  url: "..."

I'm just not sure if this should be part of this MR or you better set-up a new one? - Up to you @davidberenstein1957 :-)

[davidberenstein1957]

Hi @paulbauriegel, adding it to this MR is fine by me :) Thanks for all the help!

[paulbauriegel]

the idea was to have the same prefix redis_ for all settings same is for elasticsearch_ or other settings. I do not want to break with this pattern

[paulbauriegel]

@davidberenstein1957 I added an externalRedis config option into the values.yml enabling both an external redis cluster or just an external redis standalone. This should fix #5800
Let me know what you think

[davidberenstein1957]

LFTM! small remark w.r.t. changelof formatting.

[davidberenstein1957]

Yes, that looks clean :)