Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfc: adjust overscan numbers #1794

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

FitzRoyX
Copy link
Contributor

These coord and offset numbers will hide all empty space (including blanked active lines) without cropping any good pixels on the sides. The output now matches old ares and bsnes. Whether the blanked lines should be shown can be revisited later (most users have no idea what these are and will hate them). SMW USA 1.0, SMW EUR 1.0, and SMW EUR 1.1 were used for testing as each variant triggers each of the 3 modes and the game draws border tiles all around.

Screenshots:

SMW USA 1.0

smw_u10_overscan

smw_u10_xhideoverscan

SMW EUR 1.0

smw_e10_overscan

smw_e10_xhideoverscan

SMW EUR 1.1

smw_e11_overscan

smw_e11_xhideoverscan

Copy link
Member

@LukeUsher LukeUsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this specifically undoes the work done to make output closer to real hardware, I understand any borders are not desirable for most; so this will be merged for now while we discuss future development of display

ideally we want to be able to support three scenarios: the entire display (which is currently shown when overscan is enabled), the region that is usually shown on a CRT including correct offset and borders (currently shown when overscan disabled), or just active display (what this PR implemented for snes)

@LukeUsher LukeUsher merged commit c62e2a2 into ares-emulator:master Jan 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants