Skip to content

Fix #1566 : Port submenu section heading show at top #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

Fix #1566 : Port submenu section heading show at top #1569

merged 1 commit into from
Oct 21, 2022

Conversation

nmzaheer
Copy link
Contributor

Motivation

The Port submenu Section Heading for different protocols was being displayed at the bottom which is now corrected to show at top.

Change description

PR #1520 introduced this regression wherein the padStart method was used to fix sorting of entries in Boards and Port menu. However, this was missed for the Port Submenu Section headings.

Other information

Fixes #1566

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos self-assigned this Oct 20, 2022
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 20, 2022
@kittaakos kittaakos removed their assignment Oct 20, 2022
@kittaakos kittaakos self-requested a review October 20, 2022 15:04
kittaakos
kittaakos approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great.

From the main (93291b6) it does not work:

Screen Shot 2022-10-20 at 17 02 31

From this PR (d6afddc) it works:

Screen Shot 2022-10-20 at 17 03 25

Thank you!

@kittaakos kittaakos merged commit 5424dfc into arduino:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Port" menu section headings are located at bottom of section
2 participants
@nmzaheer @kittaakos