Updater requests elevation if needed (issue 981) #1026
+75
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Reginald Gillespie <[email protected]>
Reginald-Gillespie
force-pushed
the
main
branch
from
3c63c50 to
fb481e0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Reginald Gillespie <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
- Coverage 20.14% 19.99% -0.15%
==========================================
Files 42 43 +1
Lines 3222 3246 +24
==========================================
Hits 649 649
- Misses 2488 2512 +24
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Reginald Gillespie <[email protected]>
|
Imma be honest I have no clue what coverage and all means. |
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
-temp.exefile at boot.filename.exe-tempdue to a bug in the code, I fixed this so now it copies itself tofilename-temp.exe. According to my understanding of the code, this shouldn't cause any issues, but if someone more familiar with the code base could verify that, that would be good.What is the current behavior?
See issue 981.
What is the new behavior?
The Agent will automatically attempt to rerun itself.
Does this PR introduce a breaking change?
Nothing should be a breaking change, according to my knowledge.
Other information:
I do not own a mac, so this has not been tested on mac. However, I think my code is good, and my code only triggers when the agent was about to crash anyways, so it's not like I would have made anything worse if it didn't work on mac =P
I'm relatively new to OSS work with others, so I'm not sure if I was supposed to add tests, or what tests I would add. If tests should be added to this, those tests probably should be added by someone more experienced with unit tests and Go.
I tried to follow the contribution guidelines, I just ran the
go fmtcommand on the folder I modified because it added modified icons to a lot of other files when I ran it directly. I'm not sure if the commit signoff worked or not, nor how to check if it did.