feat: remove bufferAlgorithm param from the open command

.github/workflows/check-certificates.yml

@@ -6,6 +6,8 @@ on:
   push:
     paths:
       - ".github/workflows/check-certificates.ya?ml"
+    tags-ignore:
+      - '*'
   pull_request:
     paths:
       - ".github/workflows/check-certificates.ya?ml"

.github/workflows/publish-go-tester-task.yml

@@ -65,7 +65,7 @@ jobs:
     #use the strategy instead because we still use the native build
     strategy:
       matrix:
-        os: [ubuntu-20.04, windows-2019, macos-12]
+        os: [ubuntu-20.04, windows-2019, macos-13]
         arch: [-amd64]
         include:
           - os: windows-2019

.github/workflows/release.yml

@@ -32,7 +32,7 @@ jobs:
       prerelease: ${{ steps.prerelease.outputs.IS_PRE }}
     strategy:
       matrix:
-        os: [ubuntu-20.04, windows-2019, macos-12]
+        os: [ubuntu-20.04, windows-2019, macos-13]
         arch: [amd64]
         include:
           - os: windows-2019
@@ -116,7 +116,7 @@ jobs:
         run: |
           task go:build
           mv ${{ env.PROJECT_NAME }} ${{ env.PROJECT_NAME }}_amd64
-        if: matrix.os == 'macos-12'
+        if: matrix.os == 'macos-13'
 
       - name: Build the Agent for macos arm64
         env:
@@ -128,13 +128,13 @@ jobs:
         run: |
           task go:build
           mv ${{ env.PROJECT_NAME }} ${{ env.PROJECT_NAME }}_arm64
-        if: matrix.os == 'macos-12'
+        if: matrix.os == 'macos-13'
 
       - name: Create universal macos executable
         run: |
           lipo -create -output ${{ env.PROJECT_NAME }} ${{ env.PROJECT_NAME }}_amd64 ${{ env.PROJECT_NAME }}_arm64
           rm ${{ env.PROJECT_NAME }}_amd64 ${{ env.PROJECT_NAME }}_arm64
-        if: matrix.os == 'macos-12'
+        if: matrix.os == 'macos-13'
 
         # this will create `public/` dir with compressed full bin (<version>/<os>-<arch>.gz) and a json file
       - name: Create autoupdate files
@@ -146,7 +146,7 @@ jobs:
         run: |
           cp darwin-amd64.json darwin-arm64.json
           cp ${TAG_VERSION}/darwin-amd64.gz ${TAG_VERSION}/darwin-arm64.gz
-        if: matrix.os == 'macos-12' && steps.prerelease.outputs.IS_PRE != 'true'
+        if: matrix.os == 'macos-13' && steps.prerelease.outputs.IS_PRE != 'true'
 
       - name: Create autoupdate files for win32
         run: go-selfupdate -platform windows-${{ matrix.arch }} ${{ env.PROJECT_NAME }}${{ matrix.ext }} ${TAG_VERSION}
@@ -181,7 +181,7 @@ jobs:
       matrix:
         arch: [amd64, arm64]
 
-    runs-on: macos-12
+    runs-on: macos-13
     env:
       EXE_PATH: "skel/ArduinoCloudAgent.app/Contents/MacOS/"
 
@@ -195,7 +195,7 @@ jobs:
       - name: Download artifact
         uses: actions/download-artifact@v4
         with:
-          name: ${{ env.PROJECT_NAME }}-macos-12-amd64 # if we want to support darwin-arm64 in the future for real this has to change.
+          name: ${{ env.PROJECT_NAME }}-macos-13-amd64 # if we want to support darwin-arm64 in the future for real this has to change.
           path: ${{ env.EXE_PATH }}
 
       - name: Remove placeholder file
@@ -252,7 +252,7 @@ jobs:
       matrix:
         arch: [amd64, arm64]
 
-    runs-on: macos-12
+    runs-on: macos-13
     env:
       GON_PATH: ${{ github.workspace }}/gon
     needs: [build, create-macos-bundle]
@@ -286,6 +286,11 @@ jobs:
             -k "${{ env.KEYCHAIN_PASSWORD }}" \
             "${{ env.KEYCHAIN }}"
 
+      - name: Install Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: ${{ env.GO_VERSION }}
+
       - name: Install gon for code signing
         uses: actions/checkout@v4
         with:
@@ -509,7 +514,7 @@ jobs:
       matrix:
         arch: [amd64]
 
-    runs-on: macos-12
+    runs-on: macos-13
     steps:
       - name: Checkout repo with icons/background
         uses: actions/checkout@v4

bufferflow_timed.go

@@ -33,8 +33,8 @@ type BufferflowTimed struct {
 	bufferedOutput string
 }
 
-// NewBufferflowTimed will create a new timed bufferflow
-func NewBufferflowTimed(port string, output chan<- []byte) *BufferflowTimed {
+// NewBufferFlowTimed will create a new timed bufferflow
+func NewBufferFlowTimed(port string, output chan<- []byte) *BufferflowTimed {
 	return &BufferflowTimed{
 		port:           port,
 		output:         output,
@@ -48,7 +48,7 @@ func NewBufferflowTimed(port string, output chan<- []byte) *BufferflowTimed {
 
 // Init will initialize the bufferflow
 func (b *BufferflowTimed) Init() {
-	log.Println("Initting timed buffer flow (output once every 16ms)")
+	log.Println("Start consuming from serial port (output once every 16ms)")
 	go b.consumeInput()
 }
 

hub.go

@@ -58,7 +58,7 @@ var h = hub{
 const commands = `{
   "Commands": [
     "list",
-    "open <portName> <baud> [bufferAlgorithm: ({default}, timed, timedraw)]",
+    "open <portName> <baud>",
     "(send, sendnobuf, sendraw) <portName> <cmd>",
     "close <portName>",
     "restart",
@@ -146,15 +146,13 @@ func checkCmd(m []byte) {
 			go spErr("Problem converting baud rate " + args[2])
 			return
 		}
-		// pass in buffer type now as string. if user does not
-		// ask for a buffer type pass in empty string
-		bufferAlgorithm := "default" // use the default buffer if none is specified
+
+		// Ignore extra "buffer type" param for backward compatibility
 		if len(args) > 3 {
-			// cool. we got a buffer type request
-			buftype := strings.Replace(args[3], "\n", "", -1)
-			bufferAlgorithm = buftype
+			log.Warn(fmt.Sprintf("Unexpected arguments for the open command. Ignored arguments: '%s'.", args[3:]))
 		}
-		go spHandlerOpen(args[1], baud, bufferAlgorithm)
+
+		go spHandlerOpen(args[1], baud)
 
 	} else if strings.HasPrefix(sl, "close") {
 

serial.go

@@ -67,7 +67,7 @@ var sh = serialhub{
 func (sh *serialhub) Register(port *serport) {
 	sh.mu.Lock()
 	//log.Print("Registering a port: ", p.portConf.Name)
-	h.broadcastSys <- []byte("{\"Cmd\":\"Open\",\"Desc\":\"Got register/open on port.\",\"Port\":\"" + port.portConf.Name + "\",\"Baud\":" + strconv.Itoa(port.portConf.Baud) + ",\"BufferType\":\"" + port.BufferType + "\"}")
+	h.broadcastSys <- []byte("{\"Cmd\":\"Open\",\"Desc\":\"Got register/open on port.\",\"Port\":\"" + port.portConf.Name + "\",\"Baud\":" + strconv.Itoa(port.portConf.Baud) + "\"}")
 	sh.ports[port] = true
 	sh.mu.Unlock()
 }