Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 4, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

What is the current behavior?

  • Arduino CLI integration test CI fails with:
Retrokits-RK002:[email protected] 0 B / ?    0.00%
Retrokits-RK002:[email protected] Server responded with: 403 Forbidden
Error during install: Server responded with: 403 Forbidden
ESC[90m<<< Run completed (err = exit status 1)ESC[0m
    core_test.go:832:
           Error Trace:    /home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/core/core_test.go:832
           Error:          Received unexpected error:
                           exit status 1
           Test:           TestCoreListSortedResults
--- FAIL: TestCoreListSortedResults (3.76s)
  • CodeCov uploader fails with this error:
Traceback (most recent call last):
  File "codecov_cli/main.py", line 100, in <module>
  File "codecov_cli/main.py", line 96, in run
  File "click/core.py", line 1161, in __call__
  File "click/core.py", line 1082, in main
  File "click/core.py", line 1697, in invoke
  File "click/core.py", line 1443, in invoke
  File "click/core.py", line 788, in invoke
  File "click/decorators.py", line 33, in new_func
  File "codecov_cli/commands/upload_coverage.py", line 86, in upload_coverage
  File "click/core.py", line 788, in invoke
  File "codecov_cli/services/upload_coverage/__init__.py", line 52, in upload_coverage_logic
  File "codecov_cli/services/upload/__init__.py", line 104, in do_upload_logic
  File "codecov_cli/services/upload/upload_collector.py", line 194, in generate_upload_data
  File "codecov_cli/services/upload/upload_collector.py", line 104, in _produce_file_fixes
  File "codecov_cli/services/upload/upload_collector.py", line 118, in _get_file_fixes
FileNotFoundError: [Errno 2] No such file or directory: 'internal/integrationtest/compile_4/testdata/ValidSketchWithNonInoBrokenSketchFileSymlink/other_file.c'
[PYI-2973:ERROR] Failed to execute script 'main' due to unhandled exception!
==> Failed to run upload-coverage
    Exiting...

What is the new behavior?

CI should succeed.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

> Retrokits-RK002:[email protected] 0 B / ?    0.00%
> Retrokits-RK002:[email protected] Server responded with: 403 Forbidden
> Error during install: Server responded with: 403 Forbidden
> ESC[90m<<< Run completed (err = exit status 1)ESC[0m
>     core_test.go:832:
>            Error Trace:    /home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/core/core_test.go:832
>            Error:          Received unexpected error:
>                            exit status 1
>            Test:           TestCoreListSortedResults
> --- FAIL: TestCoreListSortedResults (3.76s)
@cmaglie cmaglie self-assigned this Nov 4, 2025
@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Nov 4, 2025
There is a bug in the codecov uploader that makes it fail when there are broken symlinks in the repository.
We must keep this workaround until the bug is fixed: codecov/codecov-action#1890
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.35%. Comparing base (f3121a3) to head (64a6afb).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
+ Coverage   68.38%   69.35%   +0.97%     
==========================================
  Files         241      241              
  Lines       22734    18585    -4149     
==========================================
- Hits        15547    12890    -2657     
+ Misses       5990     4497    -1493     
- Partials     1197     1198       +1     
Flag Coverage Δ
unit 69.35% <ø> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmaglie cmaglie changed the title fix: CI should not rely on external resources fix: CI should not rely on external resources / CI CodeCov upload workaround Nov 4, 2025
@cmaglie cmaglie requested a review from a team November 4, 2025 15:46
@cmaglie cmaglie merged commit b1ae171 into arduino:master Nov 4, 2025
173 of 174 checks passed
@cmaglie cmaglie deleted the ci_maintenance branch November 4, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] REGRESSION: v5 fails if a broken symlink is present in the repo

2 participants