Don't archive preexisting archives if commandline is too long #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
dont_archive_archives
branch
from
664ea5e to
eb1195d
Compare
This was referenced Jan 26, 2021
silvanocerza
pushed a commit
that referenced
this pull request
Jan 27, 2021
* Don't archive preexisting archives if commandline is too long Fixes https://github.com/arduino-libraries/ArduinoIoTCloud/runs/1693000682?check_suite_focus=true#step:7:277 Should revert arduino-libraries/ArduinoIoTCloud#222 * Added test Co-authored-by: Cristian Maglie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/arduino-libraries/ArduinoIoTCloud/runs/1693000682?check_suite_focus=true#step:7:277
Once merged arduino-libraries/ArduinoIoTCloud#222 can be reverted
@ubidefeo @per1234 @cmaglie
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)This patch fixes a corner case when the commandline is too long and the "archiver" kicks in.
Since archiving an archive is not really supported, we leave it as-is and just append to the list of existing archives to be linked
Compilation on ArduinoIoTCloud + ESP8266/ESP32 fails due to the huge amount of dependencies that make the commandline be over 30000 characters, WiFi.a gets added to objs.a, failing at link phase.
Everything compiles fine 🙂
titled accordingly?
See how to contribute