Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getter #26

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Rename getter #26

merged 1 commit into from
Mar 1, 2024

Conversation

sebromero
Copy link
Contributor

@sebromero sebromero commented Feb 29, 2024

This PR renames the recently added getter and bumps the version number so we can make a release.
This is necessary as another library that's in the works depends on having the getter available.

@sebromero sebromero requested a review from aentinger February 29, 2024 17:31
Copy link

Memory usage change @ c2b25b2

Board flash % RAM for global variables %
arduino:mbed_nicla:nicla_vision 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/BasicUsage
flash
% examples/BasicUsage
RAM for global variables
% examples/ReadWriteRegs
flash
% examples/ReadWriteRegs
RAM for global variables
%
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/BasicUsage<br>flash,%,examples/BasicUsage<br>RAM for global variables,%,examples/ReadWriteRegs<br>flash,%,examples/ReadWriteRegs<br>RAM for global variables,%
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7:target_core=cm4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 29, 2024
Copy link
Collaborator

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the version number, otherwise LGTM 👍

library.properties Outdated Show resolved Hide resolved
@sebromero sebromero changed the title Rename getter and bump version number Rename getter Mar 1, 2024
@aentinger aentinger merged commit f7d4cc0 into master Mar 1, 2024
15 checks passed
@aentinger aentinger deleted the rename-getter branch March 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants