Don't upload multiple times to same artifact in sketch compilation workflow #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflow The "Compile Examples" GitHub Actions workflow is configured to compile the example sketches for each of the supported boards. This is done by using a job matrix in the GitHub Actions workflow to generate a parallel job for each board. A GitHub Actions workflow artifact is used to transfer the sketches report files generated by the "arduino/compile-sketches" action between the compilation job and the "report-size-deltas" job that uses the "arduino/report-size-deltas" action to publish the data. The "actions/upload-artifact" action is used to upload the sketches report files to the workflow artifact. Previously, the sketches reports from all the boards were uploaded to a single artifact. However, support for uploading multiple times to a single artifact was dropped in version 4.0.0 of the "actions/upload-artifact" action. So it is now necessary for each of the jobs to use a separate artifact. These multiple artifacts are downloaded in aggregate in the "report-size-deltas" job by the "actions/download-artifact" action, which downloads all artifacts by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Compile Examples" GitHub Actions workflow is configured to compile the example sketches for each of the supported boards. This is done by using a job matrix in the GitHub Actions workflow to generate a parallel job for each board.
A GitHub Actions workflow artifact is used to transfer the sketches report files generated by the arduino/compile-sketches action between the compilation job and the "report-size-deltas" job that uses the arduino/report-size-deltas action to publish the data. The actions/upload-artifact GitHub Actions action action is used to upload the sketches report files to the workflow artifact.
Previously, the sketches reports from all the boards were uploaded to a single artifact. However, support for uploading multiple times to a single artifact was dropped in version 4.0.0 of the actions/upload-artifact action. Previously, the workflow did that, and so when the action was bumped (5423dc9), it caused the workflow runs to fail spuriously:
https://github.com/arduino-libraries/Arduino_NiclaSenseEnv/actions/runs/13783108129
So it is now necessary for each of the compilation jobs to use a separate artifact.
These multiple artifacts are downloaded in aggregate in the "report-size-deltas" job by the "actions/download-artifact" action, which downloads all artifacts by default.