Skip to content

Remove setThingId(THING_ID) from library examples #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Jul 21, 2022

After release 1.5.0 is no more necessary to configure the thing_id from the sketch. The board retrieves the attached thing_id from the cloud using the device_id.

Fixes #304

@github-actions
Copy link

Memory usage change @ dc03451

Board flash % RAM for global variables %
arduino:mbed:envie_m7 💚 -104 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 💚 -69 - 0 -0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 💚 -104 - 0 -0.01 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 💚 -72 - 0 -0.03 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 💚 -64 - 0 -0.02 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 💚 -64 - 0 -0.02 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 💚 -64 - -64 -0.02 - -0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 💚 -72 - 0 -0.03 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 💚 -72 - 0 -0.03 - 0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 💚 -92 - -76 -0.01 - -0.01 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 💚 -56 - -16 -0.01 - -0.0 💚 -32 - 0 -0.04 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:mbed:envie_m7 -40 -0.01 0 0.0 -104 -0.01 0 0.0 -24 -0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect -65 -0.0 0 0.0 -69 -0.0 0 0.0 -59 -0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision -104 -0.01 0 0.0 -40 -0.0 0 0.0 -88 -0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 -72 -0.03 0 0.0 -72 -0.03 0 0.0 -56 -0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 -64 -0.02 0 0.0 -64 -0.02 0 0.0 -64 -0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 -64 -0.02 0 0.0 -64 -0.02 0 0.0 -64 -0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 -64 -0.02 0 0.0 -64 -0.02 0 0.0 -64 -0.02 0 0.0
arduino:samd:mkrwifi1010 -64 -0.02 0 0.0 -72 -0.03 0 0.0 -56 -0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot -64 -0.02 0 0.0 -72 -0.03 0 0.0 -56 -0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 -84 -0.01 0 0.0 -92 -0.01 0 0.0 -76 -0.01 0 0.0
esp8266:esp8266:huzzah -32 -0.0 0 0.0 -16 -0.0 0 0.0 -56 -0.01 -32 -0.04
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m7,-40,-0.01,0,0.0,-104,-0.01,0,0.0,-24,-0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,-65,-0.0,0,0.0,-69,-0.0,0,0.0,-59,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,-104,-0.01,0,0.0,-40,-0.0,0,0.0,-88,-0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkr1000,-72,-0.03,0,0.0,-72,-0.03,0,0.0,-56,-0.02,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,-64,-0.02,0,0.0,-64,-0.02,0,0.0,-64,-0.02,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,-64,-0.02,0,0.0,-64,-0.02,0,0.0,-64,-0.02,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,-64,-0.02,0,0.0,-64,-0.02,0,0.0,-64,-0.02,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,-64,-0.02,0,0.0,-72,-0.03,0,0.0,-56,-0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,-64,-0.02,0,0.0,-72,-0.03,0,0.0,-56,-0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,-84,-0.01,0,0.0,-92,-0.01,0,0.0,-76,-0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,-32,-0.0,0,0.0,-16,-0.0,0,0.0,-56,-0.01,-32,-0.04,,,,,,,,

@pennam pennam requested a review from aentinger October 24, 2022 11:32
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! LGTM 👍

@pennam pennam merged commit 9da8516 into arduino-libraries:master Oct 27, 2022
@pennam pennam deleted the remove-thing-id-from-examples branch May 17, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ThingID from library examples
2 participants