refactor(promise-helpers): reuse promise Symbol #2408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of asking the global namespace for it every time, store the reference and put access it faster each time it's used.
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe update introduces a new changeset documenting a patch for Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant PromiseHelpers
Caller->>PromiseHelpers: fakePromise()
PromiseHelpers->>PromiseHelpers: Tag with kFakePromise symbol
Caller->>PromiseHelpers: isFakePromise(obj)
PromiseHelpers->>PromiseHelpers: Check for kFakePromise symbol
Caller->>PromiseHelpers: fakeRejectPromise()
PromiseHelpers->>PromiseHelpers: Tag with kFakePromise symbol
Caller->>PromiseHelpers: isFakeRejectPromise(obj)
PromiseHelpers->>PromiseHelpers: Check for kFakePromise symbol
Possibly related PRs
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
slagiewka
commented
May 10, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/cruel-colts-show.md (1)
5-5: Enhance changeset summary style
To follow conventional-commit and changeset conventions, consider prefixing with a type/scope (e.g.,perf(promise-helpers):) and using lowercase for consistency:- Reuse fake promise Symbol + perf(promise-helpers): reuse fake promise symbol
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/cruel-colts-show.md(1 hunks)packages/promise-helpers/src/index.ts(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: unit / node 18
- GitHub Check: unit / node 20
- GitHub Check: unit / node 23
- GitHub Check: unit / node 22
- GitHub Check: unit / deno
- GitHub Check: unit / bun
- GitHub Check: node-fetch (consumeBody)
- GitHub Check: server (native)
🔇 Additional comments (4)
packages/promise-helpers/src/index.ts (4)
4-4: Centralize and cache the fake-promise symbol lookup
Great improvement: caching the result ofSymbol.foravoids repeated global lookups and standardizes the tag across the module.
92-93: Consistently tag resolved fake promises
Adding[kFakePromise]: 'resolved'ensures every fake-resolved promise carries the same identifier for later detection.
200-201: Consistently tag rejected fake promises
Adding[kFakePromise]: 'rejected'mirrors the resolved case and makes error‐path promises discoverable via the same symbol.
317-323: Use the cached symbol in detection helpers
Refactoring bothisFakePromiseandisFakeRejectPromiseto rely onkFakePromisealigns with the new tagging approach and removes string-based lookups.
|
Thanks for the PR but I actually didn't do anything with promise helpers in my PR. |
slagiewka
commented
May 10, 2025
There was a problem hiding this comment.
Thanks for the PR but I actually didn't do anything with promise helpers in my PR.
I'm aware. I'm just pointing it out, that in order to explain that this particular change may make it slightly faster, I need to compare against something earlier. Otherwise it would seems as if I made it slower 🙂
✅
|
✅
|
✅
|
✅
|
✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of asking the global namespace for it every time, store the reference and put access it faster each time it's used.
Comparing to the published server v0.10.5 with #2383 reverted. I reverted it because even though removing of the
WeakMapimproves performance, the other changes make it dunk. When I picked changes from #1505 (and ended with the same approach as #2383 without removing public API), it was 3-5% faster.Fastify benchmarks against
node:http.many runs, actually:
Type of change
Please delete options that are not relevant.
expected)
Screenshots/Sandbox (if appropriate/relevant):
n/a
Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
This change based on current master:
Just master vs published
v0.10.5: