Skip to content

Supervised Buffer implementation #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

cpjulia
Copy link
Contributor

@cpjulia cpjulia commented Aug 13, 2025

This PR introduces the velocypack part of the supervised buffer, which is a type of buffer used together with velocypack in query processing to account memory automatically instead of having to do it by hand in every function, so everything's centralized in one place. Yet, one must still avoid accounting for memory twice inside the code for now (to be changed)

@cla-bot cla-bot bot added the cla-signed label Aug 13, 2025
Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no production change in this repository.

Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction:

I think you need to make "clear" virtual as well, it can mess with the capacity in one branch.

We also need to make sure that move works as intended with respect to memory accounting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants