-
Couldn't load subscription status.
- Fork 8
DOC-799 | Graph Visualizer improvements and updated screenshots #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1f925ce
WIP
Simran-B 155a71a
Update Visualizer screenshots
Simran-B c595f25
Merge branch 'main' of https://github.com/arangodb/docs-hugo into DOC…
Simran-B 4d61a71
Icon shortcode prototype
Simran-B 5ee3e0d
Update customization screenshot
Simran-B 0f718a1
Update descriptions
Simran-B 62860ef
DOC-813 | Implement icon shortcode and add Graph Visualizer icons
Simran-B 22d82c8
Rename icon files and mention icon shortcode to README
Simran-B 144f44d
Extend README for icon shortcode
Simran-B f1600ef
Update visual customization part
Simran-B c38b58e
Minor fixes
Simran-B cc2db4d
Fix edge styling options
Simran-B 1fc696f
Icons: Move settings icon to the canvas center
Simran-B 14003ce
Change icon shortcode image path
Simran-B c12be47
Review feedback
Simran-B 6594ebc
Fix path for icon shortcode
Simran-B d6f3359
Review feedback, mention that nodes, edges, and theming is remembered
Simran-B 49fbafa
Merge branch 'main' of https://github.com/arangodb/docs-hugo into DOC…
Simran-B e043896
Move image, add View node option
Simran-B f15a592
Merge branch 'main' into DOC-799
Simran-B File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3.66 KB
(130%)
site/content/images/graph-visualizer-menu-canvas-action.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
10 changes: 10 additions & 0 deletions
10
site/themes/arangodb-docs-theme/layouts/shortcodes/icon.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <span class="inline-icon" aria-hidden="true"> | ||
| {{- $iconName := .Get 0 }} | ||
| {{- $iconPath := printf "/images/icons/%s.svg" $iconName }} | ||
| {{- $iconSvg := readFile $iconPath }} | ||
| {{- if $iconSvg }} | ||
| {{- $iconSvg | safeHTML }} | ||
| {{- else }} | ||
| {{- errorf "Icon '%v' not found for '%v'" $iconName .Page.File.Path }} | ||
| {{- end -}} | ||
| </span> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Icon Shortcode Path Mismatch
The
iconshortcode constructs icon paths as/images/icons/NAME.svgforreadFile. However,readFileinterprets paths starting with/relative to the project root, meaning it looks inPROJECT_ROOT/images/icons/. This path doesn't match the actual icon file location insite/content/images/icons/, causing icons to be unfound and triggering an error.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and is also correct according to the Hugo docs:
https://gohugo.io/functions/os/readfile/
We can change it to
"site/content/images/icons/%s.svg"though.