Feedback

README.md

@@ -1,3 +1,5 @@
+[![Review Assignment Due Date](https://classroom.github.com/assets/deadline-readme-button-22041afd0340ce965d47ae6ef1cefeee28c7c493a6346c4f15d667ab976d596c.svg)](https://classroom.github.com/a/qGwB8rZX)
+[![Open in Visual Studio Code](https://classroom.github.com/assets/open-in-vscode-2e0aaae1b6195c2367325f4f02e2d04e9abb55f0b24a779b69b11b9e10269abc.svg)](https://classroom.github.com/online_ide?assignment_repo_id=18752380&assignment_repo_type=AssignmentRepo)
 
 # Description
 

src/Assignment6.sol

@@ -3,25 +3,30 @@ pragma solidity ^0.8.13;
 
 contract Assignment6 {
     // 1. Declare an event called `FundsDeposited` with parameters: `sender` and `amount`
+    event FundsDeposited(address indexed sender, uint256 amount);
 
     // 2. Declare an event called `FundsWithdrawn` with parameters: `receiver` and `amount`
+    event FundsWithdrawn(address indexed receiver, uint256 amount);
 
     // 3. Create a public mapping called `balances` to tracker users balances
+    mapping(address => uint256) public balances;
 
     // Modifier to check if sender has enough balance
     modifier hasEnoughBalance(uint amount) {
         // Fill in the logic using require
+        require(balances[msg.sender] >= amount, "Insufficient balance");
         _;
     }
 
     // Function to deposit Ether
     // This function should:
     // - Be external and payable
     // - Emit the `FundsDeposited` event
-    function deposit() {
+    function deposit() external payable{
         // increment user balance in balances mapping 
-
+        balances[msg.sender] += msg.value; 
         // emit suitable event
+        emit FundsDeposited(msg.sender, msg.value);
     }
 
     // Function to withdraw Ether
@@ -30,21 +35,23 @@ contract Assignment6 {
     // - Take one parameter: `amount`
     // - Use the `hasEnoughBalance` modifier
     // - Emit the `FundsWithdrawn` event
-    function withdraw() {
-        // decrement user balance from balances mapping 
+    function withdraw(uint256 amount) external hasEnoughBalance(amount) {
+        // decrement user balance from balances mapping
+        balances[msg.sender] -= amount;
 
         // send tokens to the caller
+        payable(msg.sender).transfer(amount);
 
         // emit suitable event
-
+        emit FundsWithdrawn(msg.sender, amount);
     }
 
     // Function to check the contract balance
     // This function should:
     // - Be public and view
     // - Return the contract's balance
-    function getContractBalance() {
+    function getContractBalance() public view returns(uint256){
         // return the balance of the contract
-
+        return address(this).balance;
     }
 }