-
Notifications
You must be signed in to change notification settings - Fork 35
Update to Selenium 4.35.0 +semver:feature #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated two dependency versions in pom.xml: aquality-selenium-core from 4.7.0 to 4.8.0 and jackson-databind from 2.18.2 to 2.19.2. No other files or configurations changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pom.xml (1)
73-73
: Verify Selenium 4.35.0 is pinned (and consider importing the Selenium BOM)
- We confirmed that
aquality-selenium-core:4.8.0
brings inorg.seleniumhq.selenium:selenium-java:4.35.0
as a direct dependency in its POM (see lines 119–122 of the aquality-core POM).- The project’s
pom.xml
does not declare any Selenium dependencies or a<dependencyManagement>
block, so Selenium versions are resolved transitively via Aquality.- Relying solely on transitive imports means a future upgrade of
aquality-selenium-core
could bump Selenium without notice. To lock all Selenium modules (selenium-api, remote-driver, http, etc.) to 4.35.0 and avoid drift, import the Selenium BOM in your rootpom.xml
:<dependencyManagement> <dependencies> <dependency> <groupId>org.seleniumhq.selenium</groupId> <artifactId>selenium-bom</artifactId> <version>4.35.0</version> <type>pom</type> <scope>import</scope> </dependency> </dependencies> </dependencyManagement>After this, any direct Selenium dependencies (e.g.
<artifactId>selenium-java</artifactId>
) can omit the<version>
to inherit 4.35.0 from the BOM.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
pom.xml
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: aquality-automation.aquality-selenium-java (Analyse code with SonarQube)
- GitHub Check: aquality-automation.aquality-selenium-java (Run tests)
🔇 Additional comments (1)
pom.xml (1)
83-83
: Ensure Jackson module versions remain alignedIt looks like you’ve upgraded to
jackson-databind:2.19.2
(released July 18, 2025) without bringing in the Jackson BOM, so other modules (e.g.jackson-core
,jackson-annotations
) will be picked up transitively at whatever versions your dependencies specify. This can lead to runtime conflicts if those versions differ from 2.19.2.• Location to check:
pom.xml
under<dependencies>
(around lines 81–83) declares:<dependency> <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-databind</artifactId> <version>2.19.2</version> </dependency>- No existing
<dependencyManagement>
importingjackson-bom
was found.• Action required:
Manually verify all Jackson artifacts and their resolved versions by running:
mvn dependency:tree | grep -E "com\.fasterxml\.jackson(\.|:)"
and confirm that
jackson-core
,jackson-annotations
, etc., are also at 2.19.2.To avoid future mismatches, consider importing the Jackson BOM in your POM’s
<dependencyManagement>
section:<dependencyManagement> <dependencies> <dependency> <groupId>com.fasterxml.jackson</groupId> <artifactId>jackson-bom</artifactId> <version>2.19.2</version> <type>pom</type> <scope>import</scope> </dependency> </dependencies> </dependencyManagement>Please verify the dependency tree and, if any Jackson modules resolve to a version other than 2.19.2, either align them manually or import the BOM as shown above.
No description provided.