Conversation
|
| PHP_SNAPPY_COMMIT="d31b77d63955dbbf1a302ca13c4795292f91d140" \ | ||
| PHP_SWOOLE_VERSION="v6.2.2" \ | ||
| PHP_SWOOLE_COMMIT="8e8c49915ca5f9dcb9ee654f9e336a9c88dd375e" \ | ||
| PHP_SWOOLE_VERSION="v6.2.3" \ |
There was a problem hiding this comment.
Swoole bump breaks image test The image now builds Swoole v6.2.3, but
tests.yaml still requires php --re swoole to report version 6.2.2. The container structure workflow builds this image and runs that test, so a successful build will still fail the check and block the dependency update. This assertion mirrors a version pin rather than testing Swoole behavior; replace it with an observable compatibility check instead of changing the expected string to 6.2.3.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Dockerfile
Line: 30
Comment:
**Swoole bump breaks image test** The image now builds Swoole v6.2.3, but `tests.yaml` still requires `php --re swoole` to report version 6.2.2. The container structure workflow builds this image and runs that test, so a successful build will still fail the check and block the dependency update. This assertion mirrors a version pin rather than testing Swoole behavior; replace it with an observable compatibility check instead of changing the expected string to 6.2.3.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Automated weekly dependency update.
Dependency update report
sha256:4992c6fda82eadfb3b22dca3929188dc5831e9f44a3d42b3c8d36a460b4d5a80sha256:93684051146ec037620855feb77f278090bde45ddc030801cd3f2a7685bc4deb0.21.00.21.0ced23f5b6f523.8.13.8.170087bab33ea0.7.10.7.1065a57d8fe23v1.14.0v1.14.0f3c92f68b3be2.5.22.5.33551aa91ec765.36.25.36.2f0a17c67de296.3.06.3.0df4fab2de7fc2.0.22.0.25a14bc7664230.2.30.2.3d31b77d63955v6.2.2v6.2.38b20cd39f8c13.5.33.5.3127bbcb980402.3.02.3.0c1f0d8ba5ef30.18.00.18.0c2593a4ce245Updates: 3
Dockerfile pins were updated.