-
Notifications
You must be signed in to change notification settings - Fork 215
Show warning when VCS integration is not authorized for auto-deployments #2887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,77 @@ | ||
| <script lang="ts"> | ||
| import { Trim } from '$lib/components'; | ||
| import { Link } from '$lib/elements'; | ||
| import { sdk } from '$lib/stores/sdk'; | ||
| import type { Models } from '@appwrite.io/console'; | ||
| import { | ||
| IconCode, | ||
| IconExclamation, | ||
| IconGitBranch, | ||
| IconGitCommit, | ||
| IconGithub, | ||
| IconTerminal | ||
| } from '@appwrite.io/pink-icons-svelte'; | ||
| import { ActionMenu, Layout, Popover, Icon } from '@appwrite.io/pink-svelte'; | ||
| import { ActionMenu, Layout, Popover, Icon, Tooltip } from '@appwrite.io/pink-svelte'; | ||
| import { onMount } from 'svelte'; | ||
|
|
||
| let { | ||
| deployment | ||
| deployment, | ||
| resource, | ||
| region, | ||
| project | ||
| }: { | ||
| deployment: Models.Deployment; | ||
| resource?: Models.Site | Models.Function; | ||
| region?: string; | ||
| project?: string; | ||
| } = $props(); | ||
|
|
||
| let authorized = $state<boolean | null>(null); | ||
|
|
||
| async function loadAuthorized() { | ||
| if (!resource?.installationId || !resource?.providerRepositoryId || !region || !project) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| const repository = await sdk.forProject(region, project).vcs.getRepository({ | ||
| installationId: resource.installationId, | ||
| providerRepositoryId: resource.providerRepositoryId | ||
| }); | ||
| authorized = repository.authorized; | ||
| } catch (err) { | ||
| console.warn(err); | ||
| } | ||
| } | ||
|
|
||
| onMount(() => { | ||
| loadAuthorized(); | ||
| }); | ||
| </script> | ||
|
|
||
| {#if deployment.type === 'vcs'} | ||
| <Popover padding="none" let:toggle> | ||
| <div> | ||
| <Link | ||
| on:click={(e) => { | ||
| e.preventDefault(); | ||
| toggle(e); | ||
| }}> | ||
| <Layout.Stack direction="row" gap="xs" alignItems="center"> | ||
| <Icon icon={IconGithub} size="s" /> GitHub | ||
| </Layout.Stack> | ||
| </Link> | ||
| <Layout.Stack direction="row" gap="xs" alignItems="center"> | ||
| <Link | ||
| on:click={(e) => { | ||
| e.preventDefault(); | ||
| toggle(e); | ||
| }}> | ||
| <Layout.Stack direction="row" gap="xs" alignItems="center"> | ||
| <Icon icon={IconGithub} size="s" /> GitHub | ||
| </Layout.Stack> | ||
| </Link> | ||
| {#if authorized === false} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets cosnider skeleton loader |
||
| <Tooltip> | ||
| <Icon icon={IconExclamation} size="s" color="--bgcolor-warning" /> | ||
| <span slot="tooltip"> | ||
| Integration not authorized for auto deployments.<br /> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets consider CTA, dont use "here" |
||
| To enable, add the repository to the installation settings. | ||
| </span> | ||
| </Tooltip> | ||
| {/if} | ||
| </Layout.Stack> | ||
| </div> | ||
| <svelte:fragment slot="tooltip"> | ||
| <ActionMenu.Root> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,12 +29,14 @@ | |||||
| import type { Snippet } from 'svelte'; | ||||||
|
|
||||||
| let { | ||||||
| site, | ||||||
| deployment, | ||||||
| proxyRuleList, | ||||||
| hideQRCode = false, | ||||||
| variant = 'primary', | ||||||
| footer | ||||||
| }: { | ||||||
| site: Models.Site; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. making
Suggested change
|
||||||
| deployment: Models.Deployment; | ||||||
| proxyRuleList: Models.ProxyRuleList; | ||||||
| hideQRCode?: boolean; | ||||||
|
|
@@ -208,7 +210,11 @@ | |||||
| Source | ||||||
| </Typography.Text> | ||||||
| <Typography.Text variant="m-400" color="--fgcolor-neutral-primary"> | ||||||
| <DeploymentSource {deployment} /> | ||||||
| <DeploymentSource | ||||||
| {deployment} | ||||||
| resource={site} | ||||||
| region={page.params.region} | ||||||
| project={page.params.project} /> | ||||||
| </Typography.Text> | ||||||
| </Layout.Stack> | ||||||
| </Layout.Stack> | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.