Skip to content

Conversation

@Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Oct 23, 2025

What does this PR do?

Support for TanStack site framework

Test Plan

Manual QA

Related PRs and Issues

x

Have you read the Contributing Guidelines on issues?

Yes

Summary by CodeRabbit

  • New Features

    • Added TanStack Start support with automatic detection and a dedicated color icon.
    • Integrated TanStack Starter into the web framework selector (default port 3000, npm run dev).
    • Updated framework ordering and added adapter settings for TanStack Start (SSR and static).
  • Bug Fixes

    • Fixed tooltip conditional so Retry action displays correctly during domain verifying.
  • Chores

    • Updated two dependency entries in package.json.

@railway-app
Copy link

railway-app bot commented Oct 23, 2025

This PR was not deployed automatically as @Meldiron does not have access to the Railway project.

In order to get automatic PR deploys, please add @Meldiron to your workspace on Railway.

@appwrite
Copy link

appwrite bot commented Oct 23, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Queued Queued View Logs Preview URL QR Code

Tip

You can use Avatars API to generate QR code for any text or URLs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

Walkthrough

Updated two dependency revisions in package.json. Added tanstack detection to framework icon lookup. Introduced a new TanStackFrameworkIcon Svelte component and exported it. Integrated a TanStack Starter option into the web platform creator (key: tanstack-start; smallIcon: IconTanstack; port: 3000; runCommand: npm run dev; uses VITE_‑prefixed env snippet). Inserted "TanStack Start" into framework ordering for site templates. Added tanstack-start entries to adapterDataList with SSR and static metadata. Fixed tooltip typo 'verifiying' → 'verifying'. Updated platform typing to use PlatformType.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Feat: Add TanStack support" is fully related to the main change in this changeset. The pull request implements comprehensive TanStack framework support across multiple files, including new components, framework detection logic, configuration entries, and UI integrations. The title accurately and specifically summarizes this primary objective without being vague or misleading. While a minor typo fix in a separate file is also included, the title appropriately focuses on the main change, as expected per the guidelines.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-tanstack-support

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c18218 and dbd3edd.

📒 Files selected for processing (1)
  • src/routes/(console)/project-[region]-[project]/overview/platforms/+page.svelte (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/routes/(console)/project-[region]-[project]/overview/platforms/+page.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/overview/platforms/components/index.ts (1)

7-7: Consider maintaining alphabetical order.

The export is correctly added, but placing it between NuxtFrameworkIcon and ReactFrameworkIcon breaks alphabetical ordering. Consider moving it after SvelteFrameworkIcon (line 9) to maintain consistency.

Apply this diff to improve ordering:

 export { default as NuxtFrameworkIcon } from './NuxtFrameworkIcon.svelte';
-export { default as TanStackFrameworkIcon } from './TanStackFrameworkIcon.svelte';
 export { default as ReactFrameworkIcon } from './ReactFrameworkIcon.svelte';
 export { default as SvelteFrameworkIcon } from './SvelteFrameworkIcon.svelte';
+export { default as TanStackFrameworkIcon } from './TanStackFrameworkIcon.svelte';
 export { default as VueFrameworkIcon } from './VueFrameworkIcon.svelte';
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f34f2c2 and 5b79767.

⛔ Files ignored due to path filters (3)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • static/icons/dark/color/tanstack.svg is excluded by !**/*.svg
  • static/icons/light/color/tanstack.svg is excluded by !**/*.svg
📒 Files selected for processing (7)
  • package.json (1 hunks)
  • src/lib/stores/sites.ts (1 hunks)
  • src/routes/(console)/project-[region]-[project]/overview/platforms/components/TanStackFrameworkIcon.svelte (1 hunks)
  • src/routes/(console)/project-[region]-[project]/overview/platforms/components/index.ts (1 hunks)
  • src/routes/(console)/project-[region]-[project]/overview/platforms/createWeb.svelte (3 hunks)
  • src/routes/(console)/project-[region]-[project]/sites/create-site/templates/+page.ts (1 hunks)
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/store.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: e2e
🔇 Additional comments (7)
src/lib/stores/sites.ts (1)

29-30: LGTM!

The TanStack framework detection follows the established pattern correctly and is appropriately placed before the fallback cases.

src/routes/(console)/project-[region]-[project]/overview/platforms/components/TanStackFrameworkIcon.svelte (1)

1-5: LGTM!

The component follows the same simple pattern as other framework icon components and correctly delegates to SvgIcon.

src/routes/(console)/project-[region]-[project]/sites/create-site/templates/+page.ts (1)

35-35: LGTM!

The addition of "TanStack Start" to the framework ordering is appropriately placed and maintains the logical grouping of modern frameworks.

src/routes/(console)/project-[region]-[project]/overview/platforms/createWeb.svelte (2)

23-23: LGTM!

The import addition correctly follows the existing pattern for framework icons.


42-42: LGTM!

The import addition correctly follows the existing pattern for framework components.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/store.ts (1)

56-68: LGTM!

The adapter configuration for tanstack-start follows the established pattern and includes appropriate SSR and static deployment guidance with documentation links.

package.json (1)

25-27: Dependency revisions verified as accessible.

Both updated package revisions are confirmed to exist and are available:

  • @appwrite.io/console@2736 ✓
  • @appwrite.io/pink-icons-svelte@50b60cc ✓

@Meldiron Meldiron merged commit db053cb into main Oct 24, 2025
4 checks passed
@Meldiron Meldiron deleted the feat-tanstack-support branch October 24, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants