-
Notifications
You must be signed in to change notification settings - Fork 192
Feat: Add TanStack support #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ConsoleProject ID: Sites (1)
Tip You can use Avatars API to generate QR code for any text or URLs. |
WalkthroughUpdated two dependency revisions in package.json. Added tanstack detection to framework icon lookup. Introduced a new TanStackFrameworkIcon Svelte component and exported it. Integrated a TanStack Starter option into the web platform creator (key: tanstack-start; smallIcon: IconTanstack; port: 3000; runCommand: npm run dev; uses VITE_‑prefixed env snippet). Inserted "TanStack Start" into framework ordering for site templates. Added Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/overview/platforms/components/index.ts (1)
7-7: Consider maintaining alphabetical order.The export is correctly added, but placing it between
NuxtFrameworkIconandReactFrameworkIconbreaks alphabetical ordering. Consider moving it afterSvelteFrameworkIcon(line 9) to maintain consistency.Apply this diff to improve ordering:
export { default as NuxtFrameworkIcon } from './NuxtFrameworkIcon.svelte'; -export { default as TanStackFrameworkIcon } from './TanStackFrameworkIcon.svelte'; export { default as ReactFrameworkIcon } from './ReactFrameworkIcon.svelte'; export { default as SvelteFrameworkIcon } from './SvelteFrameworkIcon.svelte'; +export { default as TanStackFrameworkIcon } from './TanStackFrameworkIcon.svelte'; export { default as VueFrameworkIcon } from './VueFrameworkIcon.svelte';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlstatic/icons/dark/color/tanstack.svgis excluded by!**/*.svgstatic/icons/light/color/tanstack.svgis excluded by!**/*.svg
📒 Files selected for processing (7)
package.json(1 hunks)src/lib/stores/sites.ts(1 hunks)src/routes/(console)/project-[region]-[project]/overview/platforms/components/TanStackFrameworkIcon.svelte(1 hunks)src/routes/(console)/project-[region]-[project]/overview/platforms/components/index.ts(1 hunks)src/routes/(console)/project-[region]-[project]/overview/platforms/createWeb.svelte(3 hunks)src/routes/(console)/project-[region]-[project]/sites/create-site/templates/+page.ts(1 hunks)src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/store.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
🔇 Additional comments (7)
src/lib/stores/sites.ts (1)
29-30: LGTM!The TanStack framework detection follows the established pattern correctly and is appropriately placed before the fallback cases.
src/routes/(console)/project-[region]-[project]/overview/platforms/components/TanStackFrameworkIcon.svelte (1)
1-5: LGTM!The component follows the same simple pattern as other framework icon components and correctly delegates to
SvgIcon.src/routes/(console)/project-[region]-[project]/sites/create-site/templates/+page.ts (1)
35-35: LGTM!The addition of "TanStack Start" to the framework ordering is appropriately placed and maintains the logical grouping of modern frameworks.
src/routes/(console)/project-[region]-[project]/overview/platforms/createWeb.svelte (2)
23-23: LGTM!The import addition correctly follows the existing pattern for framework icons.
42-42: LGTM!The import addition correctly follows the existing pattern for framework components.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/store.ts (1)
56-68: LGTM!The adapter configuration for
tanstack-startfollows the established pattern and includes appropriate SSR and static deployment guidance with documentation links.package.json (1)
25-27: Dependency revisions verified as accessible.Both updated package revisions are confirmed to exist and are available:
- @appwrite.io/console@2736 ✓
- @appwrite.io/pink-icons-svelte@50b60cc ✓

What does this PR do?
Support for TanStack site framework
Test Plan
Manual QA
Related PRs and Issues
x
Have you read the Contributing Guidelines on issues?
Yes
Summary by CodeRabbit
New Features
Bug Fixes
Chores