-
Notifications
You must be signed in to change notification settings - Fork 185
Project changes #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project changes #1829
Conversation
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-05-05 06:18:49 CET |
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-05-05 06:18:48 CET |
import { page } from '$app/state'; | ||
import { toLocaleDateTime } from '$lib/helpers/date'; | ||
|
||
let { showSelectProject = $bindable(false) } = $props(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let {
showSelectProject = $bindable(false),
}: {
showSelectProject: boolean;
} = $props();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making this change gave me an error
Property 'showSelectProject' does not exist on type '$$ComponentProps'.ts(2339)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because you need another prop to pass this data. in the org/+page.svelte
route, you are passing the projects array. but the component has a $state
variable not an exported prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like this should work -
let {
showSelectProject = $bindable(false),
selectedProjects = [],
}: {
showSelectProject: boolean;
selectedProjects: string[];
} = $props();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one comment.
projects = await sdk.forConsole.projects.list([ | ||
Query.equal('teamId', currentOrgId), | ||
Query.limit(1000) // Get all projects for organization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a very heavy operation, payload wise. The returned data is very huge. We should definitely allow more queries on this endpoint in the backend and only fetch whats needed via Query.select
later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)