Skip to content

Conversation

lohanidamodar
Copy link
Member

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented May 5, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-05-05 06:18:49 CET

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented May 5, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-05-05 06:18:48 CET

@lohanidamodar lohanidamodar requested a review from ItzNotABug May 5, 2025 06:03
@lohanidamodar lohanidamodar marked this pull request as draft May 5, 2025 06:10
@lohanidamodar lohanidamodar requested a review from ItzNotABug May 5, 2025 06:11
Base automatically changed from feat-pink-v2 to main May 18, 2025 11:13
@lohanidamodar lohanidamodar requested a review from ItzNotABug June 12, 2025 06:17
@lohanidamodar lohanidamodar requested a review from ItzNotABug June 26, 2025 06:11
import { page } from '$app/state';
import { toLocaleDateTime } from '$lib/helpers/date';

let { showSelectProject = $bindable(false) } = $props();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let {
    showSelectProject = $bindable(false),
}: {
    showSelectProject: boolean;
} = $props();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making this change gave me an error

Property 'showSelectProject' does not exist on type '$$ComponentProps'.ts(2339)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because you need another prop to pass this data. in the org/+page.svelte route, you are passing the projects array. but the component has a $state variable not an exported prop.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like this should work -

let {
    showSelectProject = $bindable(false),
    selectedProjects = [],
}: {
    showSelectProject: boolean;
    selectedProjects: string[];
} = $props();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks

Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

@lohanidamodar lohanidamodar requested a review from ItzNotABug July 3, 2025 08:35
Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one comment.

Comment on lines +36 to +38
projects = await sdk.forConsole.projects.list([
Query.equal('teamId', currentOrgId),
Query.limit(1000) // Get all projects for organization
Copy link
Member

@ItzNotABug ItzNotABug Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a very heavy operation, payload wise. The returned data is very huge. We should definitely allow more queries on this endpoint in the backend and only fetch whats needed via Query.select later.

cc @TorstenDittmann

@lohanidamodar lohanidamodar marked this pull request as ready for review July 17, 2025 09:34
@ItzNotABug ItzNotABug merged commit 9b991d1 into main Jul 17, 2025
6 checks passed
@ItzNotABug ItzNotABug deleted the feat-project-changes branch July 17, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants