Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,9 @@ jobs:
env:
HOMEBREW_TAP_TOKEN: ${{ secrets.HOMEBREW_TAP_TOKEN }}
run: |
git clone https://x-access-token:${HOMEBREW_TAP_TOKEN}@github.com/${{ github.repository_owner }}/homebrew-tap.git
# The tap is hosted under abnegate, not this repo's owner, so it
# cannot be derived from github.repository_owner.
git clone https://x-access-token:${HOMEBREW_TAP_TOKEN}@github.com/abnegate/homebrew-tap.git
Comment on lines +174 to +176

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Publishing targets lack regression coverage

The new Homebrew and APT owner literals are not covered by the regression tests described in the PR, so a future edit can let either publishing target drift from the README without failing CI and break the next release publication.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 174-176

Comment:
**Publishing targets lack regression coverage**

The new Homebrew and APT owner literals are not covered by the regression tests described in the PR, so a future edit can let either publishing target drift from the README without failing CI and break the next release publication.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

mkdir -p homebrew-tap/Formula
cp claudear.rb homebrew-tap/Formula/
cd homebrew-tap
Expand Down Expand Up @@ -272,7 +274,9 @@ jobs:
env:
APT_REPO_TOKEN: ${{ secrets.APT_REPO_TOKEN }}
run: |
git clone https://x-access-token:${APT_REPO_TOKEN}@github.com/${{ github.repository_owner }}/apt-repo.git
# The APT repo is hosted under abnegate, not this repo's owner, so it
# cannot be derived from github.repository_owner.
git clone https://x-access-token:${APT_REPO_TOKEN}@github.com/abnegate/apt-repo.git

- name: Update APT repository
env:
Expand Down