Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/SA-251: upgrading to latest notifications module #26

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Conversation

wozzer72
Copy link
Contributor

As a result of SA-251 (teams) and SA-258 (posts enrichment) upgrading to use the latest notifications modules.

Includes mapping of account ids to name - anomaly is deployed into root account (mgmt) and removing the defunct slack channel and username.

Includes upgrading the terraform lock file while here; both for latest modules and multi-platforms.

Copy link

github-actions bot commented Sep 11, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: .
Pusher: @wozzer72, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-anomaly-detection/actions/runs/10809047959

@wozzer72 wozzer72 requested a review from gambol99 September 11, 2024 09:16
@wozzer72 wozzer72 requested a review from gambol99 September 11, 2024 09:39
Copy link
Member

@gambol99 gambol99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozzer72 wozzer72 merged commit 6fffab6 into main Sep 11, 2024
11 checks passed
@wozzer72 wozzer72 deleted the feat/sa-251 branch September 11, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants