Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo on alarm name for AdministratorSSOActivity #8

Merged
merged 1 commit into from
May 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions alarms.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
resource "aws_cloudwatch_log_metric_filter" "admin_sso_activity" {
count = var.enable_administrator_sso_activity ? 1 : 0

name = "AdminitratorSSOActivity"
name = "AdministratorSSOActivity"
pattern = "{ $.userIdentity.sessionContext.sessionIssuer.userName = AWSReservedSSO_Administrator* && $.userIdentity.invokedBy NOT EXISTS && $.eventType != \"AwsServiceEvent\" }"
log_group_name = var.cloudtrail_log_group_name


metric_transformation {
name = "AdminitratorSSOActivity"
name = "AdministratorSSOActivity"
namespace = var.alarm_namespace
value = "1"
}
Expand All @@ -20,7 +20,7 @@ resource "aws_cloudwatch_metric_alarm" "admin_sso_activity" {

alarm_actions = [local.sns_topic_arn]
alarm_description = "Monitoring if anyone has used an administrative sso role to accces the accounts will ensure individually are following least privilege."
alarm_name = "AdminitratorSSOActivity"
alarm_name = "AdministratorSSOActivity"
comparison_operator = "GreaterThanOrEqualToThreshold"
evaluation_periods = "1"
insufficient_data_actions = []
Expand Down
Loading