Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EKS/RDS Extended Support Eventbridge rules #65

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

georgepstaylor
Copy link
Member

@georgepstaylor georgepstaylor commented Jan 21, 2025

This PR adds EventBridge rules and their corresponding targets (SNS) to capture AWS Billing notifications for RDS and EKS Extended Support in the eventbridge.tf file.

EventBridge rules and targets pair:

  • Added aws_cloudwatch_event_rule resource for EKS/RDS Extended Support Billing notifications. This rule pattern should capture AWS Billing notifications related to EKS/RDS Extended Support.
  • Added aws_cloudwatch_event_target resource links the rule to an SNS topic.

Copy link

github-actions bot commented Jan 21, 2025

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 👮 Terraform Security Checkov: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: .
Pusher: @georgepstaylor, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-alarm-baseline/actions/runs/12889768887

Copy link
Contributor

@shanilhirani shanilhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want these to be a conditional resource?

@georgepstaylor
Copy link
Member Author

Would we want these to be a conditional resource?

Good point - have added a boolean flag to disable these in the same way the cloudwatch alarms are.

@georgepstaylor georgepstaylor force-pushed the SA-427-aws-extended-support-alarm branch 6 times, most recently from 32014d5 to b5ef8ba Compare January 21, 2025 14:40
@georgepstaylor georgepstaylor force-pushed the SA-427-aws-extended-support-alarm branch from b5ef8ba to 599a001 Compare January 21, 2025 14:44
Copy link
Contributor

@shanilhirani shanilhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgepstaylor georgepstaylor merged commit 1574fed into main Jan 21, 2025
12 checks passed
@georgepstaylor georgepstaylor deleted the SA-427-aws-extended-support-alarm branch January 21, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants