Skip to content

fix(test): re-read the active editor tab in GlobalSearch test 7 #42129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wyattwalter wants to merge 1 commit into
base: release
Choose a base branch
from
Draft

fix(test): re-read the active editor tab in GlobalSearch test 7 #42129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/GlobalSearch_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,12 @@ describe("GlobalSearch", { tags: ["@tag.Sanity"] }, function () {
.first()
.click();
cy.wait("@createNewApi");
_.agHelper.GetObjectName().then((title) => expect(title).includes("Api"));
// The "New Query" add-tab stays active for a beat after the action is created, so
// the active tab has to be re-read until it settles on the new API. A tab that is
// still in rename mode carries its name in data-value instead of a text node.
_.agHelper.GetElement(_.locators._activeEntityTab).should(($tab) => {
expect($tab.attr("data-value") ?? $tab.text()).to.include("Api");
});
});

// since now datasource will only be saved once user clicks on save button explicitly,
Expand Down
Loading